Fix hermes-engine Podfile.lock checksum inconsistency across developers#55208
Fix hermes-engine Podfile.lock checksum inconsistency across developers#55208rolandnagy wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for the attempt. This is not the right solution because we can't make assumptions on the structure of the projects. React Native is not used from the template only, but also in several brownfield scenarios we need to consider.
In the comment, I suggested a proper fix.
You can also test the fix by building the RNTesterApp locally:
# from the react-native folder
yarn install
cd packages/rn-tester
bundle install
bundle exec pod install
open RNTesterPods.xcworkspace
yarn start
Then build and run in xcode.
| spec.user_target_xcconfig = { | ||
| 'HERMES_CLI_PATH' => "#{hermes_compiler_path}/hermesc/osx-bin/hermesc" | ||
| 'HERMES_CLI_PATH' => "${PODS_ROOT}/../../node_modules/hermes-compiler/hermesc/osx-bin/hermesc" |
There was a problem hiding this comment.
Thanks for the attempt, but this won't work.
Sure, it works for the template app specifically, but, for example, it does not work for the RNTester app we have inside the repo.
For the RNTester app, the Pods folder is located in react-native/packages/rn-tester/Pods.
Therefore ${PODS_ROOT}/../../ points to packages, which won't have a node_modules folder, so the HERMES_CLI_PATH will always fail.
The right approach here would be to keep the resolution, and then use something like Pathname#relative_path_from to compute a path that it is always correct, independently from how the project is set up.
There was a problem hiding this comment.
Thanks for pointing that out! I've updated the implementation as per your suggestion to use Pathname#relative_path_from.
rolandnagy
force-pushed
the
podfile-lock-checksum/hermes-engine
branch
from
5d9d8b5 to
7fdc8b9
Compare
rolandnagy
force-pushed
the
podfile-lock-checksum/hermes-engine
branch
from
7fdc8b9 to
c26f7d5
Compare
|
@cipolleschi I’ve addressed the changes you requested. Let me know if there's anything else needed to be done on my end. |
|
@cipolleschi Can we get this moved forward? This is a lot of noise on the consuming side... |
|
@cipolleschi can we getting this solution review/approved? |
rolandnagy
force-pushed
the
podfile-lock-checksum/hermes-engine
branch
from
c26f7d5 to
2becfaa
Compare
7 participants
Summary:
Fixed an issue where developers with identical development environments get different checksums for hermes-engine in Podfile.lock, causing unnecessary git conflicts.
The root cause was that hermes-engine.podspec used require.resolve() to get the absolute path to hermes-compiler, which included usernames. This caused the generated hermes-engine.podspec.json to differ across developers, resulting in different checksums.
See Issue: #54891
Changelog:
[IOS] [FIXED] - Fix hermes-engine Podfile.lock checksum inconsistency across developers
Test Plan:
pod installand verifiedhermes-engine.podspec.jsoncontains${PODS_ROOT}/../../node_modules/hermes-compilerpathrn-testerapp builds and runs successfully